[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.6.10 up for testing/signing

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 05 Apr 2010 11:11:31 -0400

Hyrum K. Wright wrote:
>> Thanks for the reminder. Merging the changed suggested here (r876245) does
>> indeed fix the test failure for me.
>
> Joe,
> I'm happy to +0 this patch, since it fixes the failure for me. I've no idea
> what it's doing under the hood, though, so I'd feel more comfortable if you
> were able to +1 it.

Joe's changes are solid -- he's essentially just changed the Ruby wrapper
around txdelta transmission to ignore the digest. (It passes NULL to the
underlying C function so digest calculation never occurs.) And then he, of
course, no longer returns the uncalculated digest to callers.

My only concern here is that it's a change to the Ruby API over what's
attempted in 1.6.x. If we're okay with that, you have my +1 to his fix.
But if we're trying to maintain compat in our bindings layers, we'll need to
do something different here.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-04-05 17:12:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.