[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: What revision should an added not yet commited node have?

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 16 Mar 2010 21:34:06 +0100

On Tue, Mar 16, 2010 at 09:01:28PM +0100, Daniel Näslund wrote:
> Hi!
>
> When trying to replace entries in the status code I got a couple of test
> failures saying that the revision should be 0 for newly added nodes.
> Greg pointed out that the entries code set the revision to 0 for those
> cases while the revision returned from _read_info() sets it to -1.
>
> Should we continue to use the 0 value? Is it well established as the
> revision number of version controlled, not yet committed files or should
> we tell 'svn info' and 'svn status' to not output any rev nr at all for
> these nodes?

I think -1 (invalid revnum) is more appropriate than 0.
After all, the repository has a revision 0.
We could make info and status print 'no known revision' or something
like that for added files.

But I don't know how much work it is to fix up all the code expecting 0.

Stefan
Received on 2010-03-16 21:34:39 CET

This is an archived mail posted to the Subversion Dev mailing list.