Re: What revision should an added not yet commited node have?

Daniel Näslund wrote:
> Hi!
>
> When trying to replace entries in the status code I got a couple of test
> failures saying that the revision should be 0 for newly added nodes.
> Greg pointed out that the entries code set the revision to 0 for those
> cases while the revision returned from _read_info() sets it to -1.
>
> Should we continue to use the 0 value? Is it well established as the
> revision number of version controlled, not yet committed files or should
> we tell 'svn info' and 'svn status' to not output any rev nr at all for
> these nodes?

Technically speaking, they shouldn't have a revision. SVN_INVALID_REVNUM
makes the most sense. The repository has a real revision 0, complete with
modifiable revprops, and so on, so it was a mistake for us to have ever
allowed 0 as a placeholder revision in the past.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand