C. Michael Pilato wrote:
> Greg Stein wrote:
>> On Tue, Mar 9, 2010 at 17:37, <cmpilato_at_apache.org> wrote:
>>> ...
>>> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Tue Mar 9 22:37:06 2010
>>> @@ -1268,22 +1268,49 @@ svn_wc_get_ancestry2(const char **url,
>>> result_pool, scratch_pool));
>>> }
>>>
>>> -/* Recursively mark a tree DIR_ABSPATH with a COPIED flag, skip items
>>> - scheduled for deletion. */
>>> +/* Helper for mark_tree_copied(), handling the property juggling and
>>> + state changes for a single item LOCAL_ABSPATH (of kind LOCAL_KIND). */
>>> +static svn_error_t *
>>> +mark_item_copied(svn_wc__db_t *db,
>>> + const char *local_abspath,
>>> + svn_wc__db_kind_t local_kind,
>>> + apr_pool_t *pool)
>> This new function/param should be named scratch_pool. All new funcs in
>> libsvn_wc should use the result_pool and scratch_pool naming/paradigm.
>> Pushing that out to other libraries is also a Good Thing, but
>> definitely for wc.
>
> Okey dokey.
Fixed and committed this. Thanks.
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2010-03-11 19:01:43 CET