[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 11 Mar 2010 17:58:28 +0000

On Wed, 2010-03-10, cmpilato_at_apache.org wrote:
> Author: cmpilato
> Date: Wed Mar 10 18:28:10 2010
> New Revision: 921503
>
> URL: http://svn.apache.org/viewvc?rev=921503&view=rev
> Log:
> Continue doing what it takes to get deprecated stuff into deprecated.c.
>
> * subversion/libsvn_wc/wc.h
> (svn_wc__process_committed_internal): New prototype (and real
> docstring!)

Hoorrah! Thank you, Mike.

> for what was adm_ops.c:process_committed_internal().

> (svn_wc__prop_array_to_hash): New prototype (for the function that
> was adm_ops.c:convert_to_hash()).

Excellent, too. Just one nit: it looks like you intended to rename the
argument "wcprop_changes" to "props".

- Julian

[...]
> -/* */
> -static apr_hash_t *
> -convert_to_hash(const apr_array_header_t *wcprop_changes,
> - apr_pool_t *result_pool)
> +apr_hash_t *
> +svn_wc__prop_array_to_hash(const apr_array_header_t *wcprop_changes,
> + apr_pool_t *result_pool)
[...]
> +/* Return a hash keyed by 'const char *' property names and with
> + 'svn_string_t *' values built from PROPS (which is an array of
> + pointers to svn_prop_t's) or to NULL if PROPS is NULL or empty.
> + PROPS items which lack a value will be ignored. If PROPS contains
> + multiple properties with the same name, each successive such item
> + reached in a walk from the beginning to the end of the array will
> + overwrite the previous in the returned hash.
> +
> + NOTE: While the returned hash will be allocated in RESULT_POOL, the
> + items it holds will share storage with those in PROPS.
> +
> + ### This is rather the reverse of svn_prop_hash_to_array(), except
> + ### that function's arrays contains svn_prop_t's, whereas this
> + ### one's contains *pointers* to svn_prop_t's. So much for
> + ### consistency. */
> +apr_hash_t *
> +svn_wc__prop_array_to_hash(const apr_array_header_t *wcprop_changes,
> + apr_pool_t *result_pool);
> +
> +
> /* Baton for svn_wc__compat_call_notify_func below. */
> typedef struct svn_wc__compat_notify_baton_t {
> /* Wrapped func/baton. */
>
>
Received on 2010-03-11 19:00:03 CET

This is an archived mail posted to the Subversion Dev mailing list.