[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r920522 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 8 Mar 2010 19:07:29 -0500

On Mon, Mar 8, 2010 at 16:29, <cmpilato_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Mon Mar  8 21:29:19 2010
> @@ -807,6 +807,7 @@
>   apr_pool_t *iterpool = svn_pool_create(pool);
>   const apr_array_header_t *children;
>   svn_wc__db_status_t status;
> +  svn_boolean_t base_shadowed;

I saw you tossed this already...

>...
> @@ -853,25 +856,15 @@
>                     iterpool);
>     }
>
> -  /* Handle "this dir" for states that need it done post-recursion. */
> +  /* Handle directories now, after handling their kiddos. */
>   SVN_ERR(svn_wc__db_read_info(&status, NULL, NULL, NULL, NULL, NULL, NULL,
>                                NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> -                               NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> -                               NULL, NULL,
> +                               NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +                               &base_shadowed, NULL, NULL,
>                                db, dir_abspath, iterpool, iterpool));

... but you don't need status either. This call can be eliminated.

Cheers,
-g
Received on 2010-03-09 01:08:04 CET

This is an archived mail posted to the Subversion Dev mailing list.