[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Replace entries in revision

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 9 Mar 2010 00:52:23 +0100

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: dinsdag 9 maart 2010 0:39
> To: Greg Stein; dannas_at_elego.de; dev_at_subversion.apache.org
> Subject: Re: [PATCH] Replace entries in revision
>
> Looks pretty good!
>
> Several points:
>
> * use svn_wc__internal_text_modified_p(); then you won't need wc_ctx
> (just the db)
> * read_info can return NULL for the repos_* values
> * typo in analyze_status docstring (the typename)
> * status_deleted nodes have no revision info; you may simply want to
> test for SVN_INVALID_REVNUM, since read_info() will return that when
> it is "not interesting". IOW, it does the proper work for you
> * do you need wc_root? how about just using
> svn_wc__internal_path_switched() ?

* You could optimize the checking for modifications to stop checking when
you find the first change. (You are not reporting specific changes)

        Bert
Received on 2010-03-09 00:53:06 CET

This is an archived mail posted to the Subversion Dev mailing list.