Re: svn commit: r917950 - /subversion/trunk/subversion/libsvn_client/merge.c

On Tue, Mar 02, 2010 at 11:42:25AM +0000, Philip Martin wrote:
> Philip Martin <philip.martin_at_wandisco.com> writes:
> > /** Originally intended to be used in printf()-style functions to format
> > * revision numbers. Deprecated due to incompatibilities with language
> > * translation tools (e.g. gettext).
> > *
> > * New code should use a bare "%ld" format specifier for formatting revision
> > * numbers.
> > *
> > * @deprecated Provided for backward compatibility with the 1.0 API.
> > */

Ooops, I didn't see that comment. I was using grep...

> Perhaps that doesn't apply in this case? Is this string translated?
> If it's valid to use it then we should update the svn_types.h to not
> deprecate it.

It's been deprecated for quite some time, so I'd say just leave it be.

Thanks,
Stefan
Received on 2010-03-02 12:50:47 CET