[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r917950 - /subversion/trunk/subversion/libsvn_client/merge.c

From: Philip Martin <philip_at_codematters.co.uk>
Date: Tue, 02 Mar 2010 11:42:25 +0000

Philip Martin <philip.martin_at_wandisco.com> writes:

> Stefan Sperling <stsp_at_elego.de> writes:
>
>> On Tue, Mar 02, 2010 at 10:46:47AM -0000, philip_at_apache.org wrote:
>>> Author: philip
>>> Date: Tue Mar 2 10:46:46 2010
>>> New Revision: 917950
>>>
>>> URL: http://svn.apache.org/viewvc?rev=917950&view=rev
>>> Log:
>>> * subversion/libsvn_client/merge.c (log_find_operative_revs): Use %ld
>>> rather than %d to format svn_revnum_t.
>>
>> What about using this?
>> subversion/include/svn_types.h:#define SVN_REVNUM_T_FMT "ld"
>
> /** Originally intended to be used in printf()-style functions to format
> * revision numbers. Deprecated due to incompatibilities with language
> * translation tools (e.g. gettext).
> *
> * New code should use a bare "%ld" format specifier for formatting revision
> * numbers.
> *
> * @deprecated Provided for backward compatibility with the 1.0 API.
> */

Perhaps that doesn't apply in this case? Is this string translated?
If it's valid to use it then we should update the svn_types.h to not
deprecate it.

-- 
Philip
Received on 2010-03-02 12:43:04 CET

This is an archived mail posted to the Subversion Dev mailing list.