[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix failing ci caused in r40202

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 05 Feb 2010 09:21:21 +0000

Kannan wrote:
> Julian Foad wrote:
> > But that's not right. Like I said before, the variable holds different
> > kinds of data at different times. (If we this variable was intended to
> > always hold a URL, we would want the variable's name to indicate so.)
> >
> > It is wrong to call svn_uri_canonicalize() on a string that is not known
> > to be a URL. Depending on what the string is, that might change it in
> > some undesired way.
> >
> Thought cdata->data only holds a URL(after chasing their values in gdb).
> Thanks for the clarification. So, canonicalization should be done in the
> two places where required rather than doing it initially? If so, will
> send the updated patch.



- Julian
Received on 2010-02-05 10:22:01 CET

This is an archived mail posted to the Subversion Dev mailing list.