[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix failing ci caused in r40202

From: Kannan <kannanr_at_collab.net>
Date: Fri, 05 Feb 2010 10:54:40 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
> But that's not right. Like I said before, the variable holds different
> kinds of data at different times. (If we this variable was intended to
> always hold a URL, we would want the variable's name to indicate so.)
>
> It is wrong to call svn_uri_canonicalize() on a string that is not known
> to be a URL. Depending on what the string is, that might change it in
> some undesired way.
>

Thought cdata->data only holds a URL(after chasing their values in gdb).
Thanks for the clarification. So, canonicalization should be done in the
two places where required rather than doing it initially? If so, will
send the updated patch.

>> Though there's one more place:
>>
>> <snip>
>>
>> case ELEM_status:
>> /* Parse the <status> tag's CDATA for a status code. */
>> if (ne_parse_statusline(cdata, &status))
>> return svn_error_create(SVN_ERR_XML_MALFORMED, NULL, NULL);
>>
>> </snip>
>>
>> that does not need the canonicalized value, thought its better to do the
>> canonicalization in just one place.
>
> No. (And there are several other places where the variable is used in
> that function, where the value it holds is something other than a URL.)

Yup, saw them after sending the mail :( Thank you Julian.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBS2url3lTqcY7ytmIAQJLcgf/TcgXB4fxNTZ47zRuRm2XiX3aIp3kMd7y
eBFTozasjSKVTak0KydXZZkyK/9vMv1IprHy08eWU+jq9ryEc/d4vXm5PKZgyQ3e
J9XQ5+Vq48WtpDoIIGVKvuYgp9a6bdIw9Ho2s5LoYmiEEaqHBRuW2mgrlBUxK1D1
FQfyD21gVZdptxb4wzaPKYl5vQHJ0zodxTRHsjxJNFhMZV6uPJeN6z7qUf554+z7
7gcqLkD8gLjnMGTLJWUMAh9syQ7pkKvPTNt4HmiqlJIvugIgPvdv0gbQrU7j+adt
5GfoKQnDRnVHGmamEgIavtPK/X5fy4HbEWY+n/V/YZJ8uXH6CTzeCA==
=McpW
-----END PGP SIGNATURE-----
Received on 2010-02-05 06:25:23 CET

This is an archived mail posted to the Subversion Dev mailing list.