On Tue, Feb 02, 2010 at 06:46:46PM +0100, Bert Huijben wrote:
> I like this change for my uses of 'svn' as '*' is handled by the
> shell, but I don't think the new functionality is logical at the
> svn_client_add() layer. In most gui clients I use, I see some svn
> status output containing the not added files and then these clients
> allow adding all or some of the files via the explicit variant.
>
> Just notifying that you skipped a few files that would have been added
> before, would make it very hard for api users to replicate the old
> behavior via the new api. (Using the notify handler to check for error
> conditions is not so easy for most api users)
Right now, the no_ignore parameter only disables global ignores,
and svn:ignore ignores are always ignored.
Could a gui client not get the ignore list for the directory,
and let the user toggle no_ignore for any particular file in the list,
and then call svn_client_add4() with the appropriate value for the
no_ignore parameter?
> Not sure if the same applies for scripts that use svn internally...
> but I would guess most batch files have a hard time making sense of
> the changing svn status output for warning conditions. (Would this
> break svnmerge.py like wrapper scripts?)
Changing output always break badly written scripts.
IMO that should not make us hesitate to improve the output.
Stefan
Received on 2010-02-02 19:21:26 CET