On Tue, 2009-12-22, Kannan wrote:
> I (Kannan) wrote:
> [..]
> >>> (svn_ra_neon__exchange_capabilities): Same.
> >> And this?
>
> > Trying to find them out.
>
> With regard to this change, AFAICS the `activity_collection' value is
> set in `svn_ra_neon__request_dispatch' where its obtained in the body of
> the response as xml(once the session is established). It's assignment to
> the our variable `oc' couldn't be traced (rather implicit) :( Hope it
> should be canonicalized as in the patch, please CMIIW.
I looked for assignments to the "activity_coll" field, and found it in
the function end_element(), where it copies it from the "cdata" field. I
think that is where the canonicalization should be done.
And here:
> * props.c
> (svn_ra_neon__get_baseline_info, svn_ra_neon__get_one_prop): Same.
The function ..._get_baseline_info() gets its bc_url from a hash created
by the function svn_ra_neon__get_baseline_props(), so I think that's
where the change needs to be.
The function "get_one_prop" is not specifically for getting a baseline
URL, it is a generic function for getting any property, so I think you
should not be changing that function.
- Julian
Received on 2010-01-06 17:39:48 CET