[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: segfault in 1.6.6

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 18 Nov 2009 21:00:16 +0100

On Wed, Nov 18, 2009 at 07:17:44PM +0100, Stefan Küng wrote:
> Since the repo is now readonly and my ICLA for the apache repo is still
> in status 'sent', here's my patch for this.
> This should of course get nominated for backport since I discovered this
> with 1.6.6.

> [[[
> Avoid a segfault when committing.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (get_writable_proto_rev_body) : pass a valid memory pool instead of 0 to
> svn_io_file_seek().
> ]]]
> Index: subversion/libsvn_fs_fs/fs_fs.c
> ===================================================================
> --- subversion/libsvn_fs_fs/fs_fs.c (revision 40515)
> +++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
> @@ -798,7 +798,7 @@
> if (!err)
> {
> apr_off_t offset = 0;
> - err = svn_io_file_seek(*file, APR_END, &offset, 0);
> + err = svn_io_file_seek(*file, APR_END, &offset, pool);
> }
>
> if (err)

Committed in r881905.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2419673
Received on 2009-11-18 21:00:41 CET

This is an archived mail posted to the Subversion Dev mailing list.