[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sun, 15 Nov 2009 14:39:57 +0100

On Fri, Nov 13, 2009 at 6:06 AM, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
> 2009-11-09 14:51:28 Greg Stein napisaƂ(a):
>> On Sun, Nov 8, 2009 at 05:17, Stefan Sperling <stsp_at_elego.de> wrote:
>> > On Sun, Nov 08, 2009 at 07:30:36AM +0100, Branko Cibej wrote:
>> >> Verdict: -1, please revert this change.
>> >
>> > +1 on revert, and simply removing #include <svn_debug.h> from
>> > svn_types.h and requiring people who use SVN_DBG to include svn_debug.h
>> > manually.
>>
>> I put the include into svn_types.h to make our lives easier. Without
>> that, then we'll end up with svn_debug.h scattered around (as noted by
>> Arfrever's removal of them).
>
> Why don't you use svn_private_config.h? It's included in even more files
> than svn_types.h:
>
> $ grep -Er '#include[[:space:]]+"svn_private_config\.h"' subversion | grep -v /\.svn/ | wc -l
> 273
> $ grep -Er '#include[[:space:]]+"svn_types\.h"' subversion | grep -v /\.svn/ | wc -l
> 168

I like the idea of using svn_private_config.h, but these numbers by
itself don't tell the full story. Almost all of our headers include
svn_types.h, so you don't have to include it directly. And you are
only counting direct includes.

   Bert
>
> --
> Arfrever Frehtes Taifersar Arahesis
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2418141
Received on 2009-11-15 14:40:14 CET

This is an archived mail posted to the Subversion Dev mailing list.