[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Wed, 11 Nov 2009 21:48:22 +1100

Hi Martin,

Just thought I would chase up whether or not you were gong to follow-on with this patch submission and the extra information provided by Julian?
(And while I am sure you know already - you should feel at ease asking for any help that you might need.)

I only ask so that I know whether or not keep an eye on this particular thread or not.

Gavin.

On 10/11/2009, at 01:36 , Julian Foad wrote:

> Gavin Baumanis wrote:
>> I have logged issue #3520:
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3520
>
>
>>> On 26/10/2009, at 05:34 , Martin Hauner wrote:
>>>> another scratch_pool patch.
>>>>
>>>> Note that there is an issue in close_directory. A result gets allocated
>>>> in the scratch_pool. I can't add a result_pool because it is a callback
>>>> implementation.
>>>>
>>>> Should I do anything here?
>>>>
>>>> See
>>>> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462
>
> That looks like a bug in libsvn_wc/status.c:close_directory(), currently
> line 1857:
>
> eb->anchor_status​->ood_last_cmt_au​thor =
> apr_pstrdup(pool, db->ood_last_cmt_author);
>
> I don't believe it should allocate stuff in the edit baton from its
> passed-in "pool". I think we need to add a pool pointer in the edit
> baton, and initialize it to a pool that has the correct life time.
>
> - Julian
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415797

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416481
Received on 2009-11-11 11:48:49 CET

This is an archived mail posted to the Subversion Dev mailing list.