[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 09 Nov 2009 14:36:38 +0000

Gavin Baumanis wrote:
> I have logged issue #3520:
> http://subversion.tigris.org/issues/show_bug.cgi?id=3520

> > On 26/10/2009, at 05:34 , Martin Hauner wrote:
> >> another scratch_pool patch.
> >>
> >> Note that there is an issue in close_directory. A result gets allocated
> >> in the scratch_pool. I can't add a result_pool because it is a callback
> >> implementation.
> >>
> >> Should I do anything here?
> >>
> >> See
> >> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462

That looks like a bug in libsvn_wc/status.c:close_directory(), currently
line 1857:

    eb->anchor_status​->ood_last_cmt_au​thor =
      apr_pstrdup(pool, db->ood_last_cmt_author);

I don't believe it should allocate stuff in the edit baton from its
passed-in "pool". I think we need to add a pool pointer in the edit
baton, and initialize it to a pool that has the correct life time.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415797
Received on 2009-11-09 15:37:04 CET

This is an archived mail posted to the Subversion Dev mailing list.