Re: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

Bert Huijben wrote:
> The extractor.py changes were reverted, which added the functions back to
> the public dll api.. but the functions itself were not defined in release
> mode.
>

That is a correct change. We should *always* have all functions defined
and available in libraries, regardless of whether they're "disabled" by
some macro or not. This allows, e.g., a debug build of some file to link
with release libraries and not freak out in the process.

(Doing this wrong first bit me with some early version of MS Visual
Studio (6 maybe?) where you couldn't make a release build without
defining NDEBUG because the function that implemented the assert() macro
was not linked into their release library. I learned a few new swear
words then.)

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415744
Received on 2009-11-09 11:51:08 CET