[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Mon, 9 Nov 2009 11:40:22 +0100

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> Sent: zondag 8 november 2009 23:26
> To: Arfrever Frehtes Taifersar Arahesis
> Cc: Branko ─îibej; Stefan Sperling; Subversion Development; Bert Huijben
> Subject: Re: svn commit: r40417 - in trunk: . subversion/include
> subversion/include/private subversion/libsvn_client
> subversion/libsvn_subr subversion/libsvn_wc
>
> Arfrever Frehtes Taifersar Arahesis wrote on Sun, 8 Nov 2009 at 23:03
> +0100:
> > I'm not missing any point, because I haven't said that your arguments
> are
> > incorrect. I only didn't have time to revert these changes.
>
> It would be extremely helpful if you communicated that you acknowledge
> the
> veto (i.e., that you know it was uttered). By ignoring it completely
> you
> leave a very bad impression that can be very easily misinterpreted.

I reverted some further changes on subversion/libsvn_subr/debug.c which
broke the shared library support on Windows, per the hacking.html rule:
"To prevent loss of productivity, any committer (full or partial) can
immediately revert any build system change that breaks their ability to
effectively do development on their platform of choice, as a matter of
ordinary routing, without fear of accusations of an over-reaction. The log
message of the commit reverting the change should contain an explanatory
note saying why the change is being reverted, containing sufficient detail
to be suitable to start off a discussion of the problem on dev@, should
someone chose to reply to the commit mail."

The extractor.py changes were reverted, which added the functions back to
the public dll api.. but the functions itself were not defined in release
mode.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415738
Received on 2009-11-09 11:40:43 CET

This is an archived mail posted to the Subversion Dev mailing list.