Re: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

2009-11-07 20:27:54 Bert Huijben napisał(a):
> > -----Original Message-----
> > From: Arfrever Frehtes Taifersar Arahesis
> > [mailto:Arfrever.FTA_at_GMail.Com]
> > Sent: zaterdag 7 november 2009 12:14
> > To: svn_at_subversion.tigris.org
> > Subject: svn commit: r40417 - in trunk: . subversion/include
> > subversion/include/private subversion/libsvn_client
> > subversion/libsvn_subr subversion/libsvn_wc
> >
> > Author: arfrever
> > Date: Fri Nov 6 15:14:00 2009
> > New Revision: 40417
> >
> > Log:
> > Fix inclusion of svn_debug.h. Previously this private header was
> > included from
> > public header (svn_types.h) when SVN_DEBUG was defined. It was causing
> > build
> > failures when including installed svn_types.h with SVN_DEBUG defined.
> > Now
> > svn_debug.h is automatically included when SVN_DEBUG is defined during
> > building
> > of Subversion, but isn't included from installed svn_types.h when
> > SVN_DEBUG is
> > defined.
>
>
> What do you try to fix?

Public headers shouldn't include private headers.

> SVN_DEBUG is an internal switch we use for debugging subversion itself. It should not be set by user code. And our own compilation should never use an installed svn_types.h, or we can never change this file again.
>
> This breaks my debug/test builds where I use SVN_DBG() in source files (e.g. all over libsvn_wc).

What exactly errors do you get? Does '#include "private/svn_debug.h"' avoid them?

> The follow-ups also break exporting the debug helpers on windows...

Can the debug helpers be used if svn_debug.h is directly included?

> it makes it impossible to use SVN_DBG() in a shared build?

This commit should identically affect shared and static build.

> It also breaks a static debug compilation in dso.c (in libsvn_subr)

What error exactly?

> #ifdef SVN_DEBUG
> char buf[1024];
> SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
> #endif
>
>
> So Again: What problem did you want to fix?
>
> Did you try this patch in debug and release builds?

Yes, but not on Windows.

> And did you try using SVN_DBG() in a file like update_editor.c?

It works without problems for me (in debug mode).

-- 
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415497