RE: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc
From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sat, 7 Nov 2009 20:27:54 +0100
> -----Original Message-----
What do you try to fix?
SVN_DEBUG is an internal switch we use for debugging subversion itself. It should not be set by user code. And our own compilation should never use an installed svn_types.h, or we can never change this file again.
This breaks my debug/test builds where I use SVN_DBG() in source files (e.g. all over libsvn_wc). The follow-ups also break exporting the debug helpers on windows... it makes it impossible to use SVN_DBG() in a shared build?
It also breaks a static debug compilation in dso.c (in libsvn_subr)
#ifdef SVN_DEBUG
So Again: What problem did you want to fix?
Did you try this patch in debug and release builds?
We intended never to commit usages of SVN_DBG(), but it was not added as something we will never use.
Are you going to fix this?
Bert
------------------------------------------------------
|
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.