[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] addcommand line option to svn-backup-dumps.py to specify svnadmin and svnlook paths

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 4 Nov 2009 00:58:27 +0200 (Jerusalem Standard Time)

masaru tsuchiyama wrote on Tue, 3 Nov 2009 at 21:39 +0900:
> Hi. Daniel
>
> 2009/10/24 Daniel Shahaf <d.s_at_daniel.shahaf.name>:
> > Senthil Kumaran S wrote on Sat, 24 Oct 2009 at 12:41 +0530:
> >> --svnadmin-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnadmin
> >> --svnlook-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnlook
> >
> > Won't it always be necessary to provide either both of these or neither of
> > them? In that case it might be better to have just one arg, e.g.,
> >
> > --svn-path=/home/stylesen/work/builds/pure-trunk-neon/bin
> >
> > and then
> >
> > svnadmin_path = os.path.join(svn_path, 'svnadmin')
> > svnlook_path = os.path.join(svn_path, 'svnlook')
> >
> > in the script.
> >
>
> Sorry fo very late reply.
>
> I had sent another patch to add a feature to specify bzip2 and gzip paths
> --bzip2-path and --gzip-path option. (The patch was committed at r40147)
>
> If the option is specified, bzip2 or gzip is used to compress instead of
> python module.
>
> That patch also takes paths to bzip and bzip executables.
>
...
>
> For consistency, I added the options to specify svnadmin and svnlook paths.
>

*nod* fair enough. If someone's svnadmin isn't in $PATH, they can just
use a shell variable to save their typing then (and it's also more
general the way it is).

Let's leave it the way it is then. Thanks for explaining :)

Daniel

> Regards.
> Masaru.
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414234
Received on 2009-11-03 23:58:42 CET

This is an archived mail posted to the Subversion Dev mailing list.