Re: [PATCH] addcommand line option to svn-backup-dumps.py to specify svnadmin and svnlook paths

Hi. Daniel

2009/10/24 Daniel Shahaf <d.s_at_daniel.shahaf.name>:
> Senthil Kumaran S wrote on Sat, 24 Oct 2009 at 12:41 +0530:
>> --svnadmin-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnadmin
>> --svnlook-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnlook
>
> Won't it always be necessary to provide either both of these or neither of
> them? In that case it might be better to have just one arg, e.g.,
>
> --svn-path=/home/stylesen/work/builds/pure-trunk-neon/bin
>
> and then
>
> svnadmin_path = os.path.join(svn_path, 'svnadmin')
> svnlook_path = os.path.join(svn_path, 'svnlook')
>
> in the script.
>

Sorry fo very late reply.

I had sent another patch to add a feature to specify bzip2 and gzip paths
--bzip2-path and --gzip-path option. (The patch was committed at r40147)

If the option is specified, bzip2 or gzip is used to compress instead of
python module.

That patch also takes paths to bzip and bzip executables.

If bzip2 and gzip are in a dir of 'PATH' environment variable,
a user can use --bzip2-path=bzip2 or --gzip-path=gzip.
If the options take dirs to bzip2 and gzip, a user must
specify the absolute or relative dir to the commands.

So I decided that the options take the paths to the commands.

For consistency, I added the options to specify svnadmin and svnlook paths.

Regards.
Masaru.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414098
Received on 2009-11-03 13:39:54 CET