[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Kannan <kannanr_at_collab.net>
Date: Wed, 28 Oct 2009 18:41:33 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stefan Sperling wrote:
> On Mon, Oct 26, 2009 at 07:25:35PM +0530, Kannan wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>>
>> Log:
>> Resolve a deprecation warning.
>>
>> * subversion/svn/info-cmd.c
>> (svn_cl__info): Use `svn_client_info3()'.
>>
>> Patch by: Kannan R <kannanr_at_collab.net>
>
>> Index: subversion/svn/info-cmd.c
>> ===================================================================
>> --- subversion/svn/info-cmd.c (revision 40224)
>> +++ subversion/svn/info-cmd.c (working copy)
>> @@ -527,7 +527,7 @@
>> && (peg_revision.kind == svn_opt_revision_unspecified))
>> peg_revision.kind = svn_opt_revision_head;
>>
>> - err = svn_client_info2(truepath,
>> + err = svn_client_info3(truepath,
>> &peg_revision, &(opt_state->start_revision),
>> receiver, NULL, opt_state->depth,
>> opt_state->changelists, ctx, subpool);
>
> Are you sure you don't need to update the receiver also?
>
> svn_client_info2's docstring says:
>
> /** Similar to svn_client_info3, but uses an svn_info_receiver_t instead of
> * a svn_info_receiver2_t.

Thank you stsp. After your comments in IRC, changed the receiver type to
`svn_info_receiver2_t' and passed the path as absolute to
`svn_client_info3()' as it expects an 'abspath_or_url', also to avoid an
assertion failed error in `svn_wc__db_read_info()' and just tested `svn
info'. It runs fine, before I could change anything in `print_info()'.
I'm attaching the patch herewith. Please correct me if I'm wrong.

- --
Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSuhDBHlTqcY7ytmIAQLk+wgAjezuiOofayrjtaJKv+9JdKdTN2wL+kmz
CAZXbjpJ9LC3DH8EGEcWrj1eikMalzmW2RrYDiMdIrPOZfcsXM/kpP/jkpg560Sj
BZ4vl9+1BqnbfpRESB1fLYJg8UIlkVJrNoUvl2snYy/oUq6pUtcO4To/70Y7josz
DvmowuKrhofD1Gd6v4uN95gL8N1LUx2FX86xY0dj7XcMn2YZRY4E3Lg1EoGx2Pky
+DBELVYBw0HARo5zuawCynhX09sc3ye7q9WqRogd6GOXgX1Jqbjyd4traLRvSltW
CZKbEv58GibwgSbesxr4rcI2NoSMYITcOo60VIcaFt0/S82QejCqaA==
=w/o1
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2412106

Received on 2009-10-28 14:12:36 CET

This is an archived mail posted to the Subversion Dev mailing list.