[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: Re: Issue #2580 revisited: Windows unclean TCP close [SEVERE]

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 24 Oct 2009 23:38:10 +0200 (Jerusalem Standard Time)

Stefan Sperling wrote on Sat, 24 Oct 2009 at 21:40 +0200:
> I'll ask Bert, Paul and Daniel to take a look at this thread.
> If they don't have any concerns I'd say let's just commit your patch
> and hope that this stupid issue will finally die...
>

Okay, with help from Stefan, took the patch for a quick drive.

My observetions:

* Without the patch, the TCP SSH connection closes with RST.

* With the patch, it closes with double-ended FIN.

* I don't see any leftover processes on the windows client side.

* I tested both with svn+ssh:// and with the two svn+custom:// schemes
  that I use regularly.

* I see leftover processes on the server side only when the script that
  my ssh tunnel runs (on the server) doesn't pass "-q 0" to /bin/nc.
  (On Ubuntu that's the "quit N seconds after EOF on stdin" flag.)

* For testing I used the svn client (fresh trunk) and putty/plink 0.60.
  I didn't test connection pooling because I didn't find the putty
  equivalent of openssh's ControlMaster option.

Bottom line: +0 because FIN is better than RST, I don't see any
ill effects, and there is no previous report of zombies on windows
(per Stefan's last mail).

Daniel

> Stefan
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411087
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411095
Received on 2009-10-24 23:38:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.