Re: [PATCH] addcommand line option to svn-backup-dumps.py to specify svnadmin and svnlook paths

masaru tsuchiyama wrote:
> Hi.
>
> I added the feature to specify svnadmin and svnlook paths
> by command line options.
>
> [[[
> add two command line options, --svnadmin-path and --svnlook-path
> to svn-backup-dumps.py
>
> When --svnlook-path option is specified, use the parameter as
> svnlook path to get the youngest revision of a repository.
>
> When --svnadmin-path option is specified, use the parameter as
> svnadmin path to dump a repository.
>
> * tools/server-side/svn-backup-dumps.py
> (SvnBackup.__init__): add two member variables, __svnadmin_path and
> __svnlook_path to hold command line parameters
> (SvnBackup.get_head_rev): use the member variable __svnlook_path instead
> of contant string "svnlook".
> (SvnBackup.create_dump): use the member variable __svnadmin_path instead
> of contant string "svnadmin".
> ]]]

Committed in r40215 and tested as follows,

<snip>
$ ./tools/server-side/svn-backup-dumps.py -b /tmp/repos1 /tmp
svnlook: Expected FS format between '1' and '3'; found format '4'

An error occured!
$ ./tools/server-side/svn-backup-dumps.py -b
--svnlook-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnlook
/tmp/repos1 /tmp
writing /tmp/repos1.000000-000000.svndmp.bz2
svnadmin: Expected FS format between '1' and '3'; found format '4'

An error occured!
$ rm /tmp/repos1.000000-000000.svndmp.bz2
$ ./tools/server-side/svn-backup-dumps.py -b
--svnadmin-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnadmin
--svnlook-path=/home/stylesen/work/builds/pure-trunk-neon/bin/svnlook
/tmp/repos1 /tmp
writing /tmp/repos1.000000-000000.svndmp.bz2
* Dumped revision 0.

Everything OK.
</snip>

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410844