[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Fri, 23 Oct 2009 15:35:44 +0530

Julian Foad wrote:
> On Fri, 2009-10-23 at 14:34 +0530, Kannan wrote:
>> Log:
>> Resolve some deprecation warnings and a bit of formatting.
>>
>> * subversion/libsvn_subr/target.c
>> (svn_path_condense_targets): Use `svn_dirent_get_absolute()',
>> `svn_dirent_get_longest_ancestor()' and `svn_dirent_is_root()'.
>
> The doc string of svn_path_condense_targets() indicates it can operate
> on dirents or URLs. I don't think you can simply change the
> implementation like this without checking which kind of targets they
> are.

Also I think there is no point in changing the logic of an already deprecated
public API (svn_path_condense_targets) and handle the overhead of revving the
API for this/similar may be new change in logic.

>> (svn_path_remove_redundancies): Use `svn_dirent_get_absolute()' and
>> `svn_dirent_is_child()'.
>
> Does the same apply here? I haven't checked.

Looking at the consumer (only one) of this API 'svn_client_commit4' it looks
like an URL will not be passed to 'svn_path_remove_redundancies', but the above
change does change the logic of the public API which may require a API revving
(I don't know in which version 'svn_path_remove_redundancies' API was
introduced, not obvious from the doc string).

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410598
Received on 2009-10-23 12:06:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.