[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #2580 revisited: Windows unclean TCP close [SEVERE]

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 22 Oct 2009 10:50:53 +0200

On Wed, Oct 21, 2009 at 10:33:32PM -0700, Paul Charlton wrote:
> I did read this entire thread ... the problem is the linux sshd/child
> process, per http://tools.ietf.org/html/rfc1122#page-87, see section
> 4.2.2.13.
> Just for kicks, also see
> http://en.wikipedia.org/wiki/Transmission_Control_Protocol#Connection_termin
> ation
>
> Under this situation, I would not advocate changing the windows
> implementation to "correct" the mis-behavior of the linux sshd and its child
> process.

What would you suggest doing instead?

If Bob's patch fixes the problem without causing undesired side-effects,
then that's fine by me.

(I'm not going to commit the patch myself simply because I cannot test
it since I don't have a Windows machine. And I'd rather see the effects
of what I commit with my own eyes.)

> Also, to quote your original post -- "sshd goes into bozo mode and leaves
> its svnserve subprocess running." I haven't looked into the sources, but if
> I recall correctly, sshd under this circumstance is sending "SIGHUP" to the
> child process (svnserve), giving it the opportunity to flush buffers ...
> which would mean that svnserve is not responding correctly to external
> signals.

The default action for SIGHUP is terminating the process.
I don't see anything in the svnserve source code overriding SIGHUP.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410122
Received on 2009-10-22 10:51:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.