[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40135 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 20 Oct 2009 16:19:27 -0400

On Tue, Oct 20, 2009 at 16:01, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
> I don't know if this is a safe transformation, but previously the log_accum
> and the delete were queued at once in an all or nothing operation.
> (Transactioned).
> We can now fail between the flushing of the log and the queueing of the
> queuing of the delete lock.
> These two operations should be added to the wq in one transaction or
> everything should be in one wq operation if we don't want to change the
> behavior.

While it is true that we have reduced the atomicity of
queue-insertions, this work is simply a stepping stone. We'll be
migrating to larger/higher-level-semantics for work queue operations
at some point. Further, we'll get them inserted into the queue,
transactionally, as we change other, related metadata in the database.

But that is a little ways off, and these kinds of changes will make it
easier for us to get there. We'll just live with this slightly higher
potential for mid-queueing errors leaving partial work in the queue.


Received on 2009-10-20 22:20:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.