[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39598 - in trunk/subversion: include libsvn_wc

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 20 Oct 2009 12:20:01 +0100

On Tue, 2009-10-20, Senthil Kumaran S wrote:
> Greg Stein wrote:
> > Internal pools are evil, and lead to significant troubles when not
> > handled properly.
> >
> > I'd suggest treating conflicts as immutable, thus never needing further
> > allocs or an internal pool.
>
> Which results in this warning,
>
> <snip>
> ../subversion/libsvn_wc/conflicts.c: In function ‘svn_wc_conflict_dup’:
> ../subversion/libsvn_wc/conflicts.c:95: warning: assignment discards qualifiers
> from pointer target type
> </snip>

I removed the internal pool in r40125. I didn't go any further towards
making the structure "immutable" because Bert says he's totally
re-designing it.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2409343
Received on 2009-10-20 13:20:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.