[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #2580 revisited: Windows unclean TCP close [SEVERE]

From: Branko Cibej <brane_at_xbc.nu>
Date: Sat, 17 Oct 2009 14:34:20 +0200

Bob Denny wrote:
> Hi Branko --
>
> Thanks for the reply! I have been pushed away from a couple of open source
> projects in the past, so I do appreciate you and Stefan listening :-)
>
> Branko:
>
>> I think we need some hard data in order to make a reasonable decision
>> here. Bob, since you see and presumably can reproduce this
>> indiscriminate proliferation of daemons; could you possibly test your
>> assumption that KILL_NEVER does the right thing on Windows? It would
>> require modifying and recompiling Subversion.
>>
>
> I've already done this with svn 1.6.5 and Linux based svn servers, and I'm
> running it here in production. Actually I checked out the TortoiseSVN tree which
> contains svn 1.6.5 and built THAT, but it results in both Tortoise as well as
> svn 1.6.5 *client side* and libraries. Both are working perfectly now.

OK; I think that's as much confirmation we need. I believe this code
hasn't changed since 1.6.5.

[...]
> If I need to make Subversion so I can test against a WINDOWS ssh/svnserve I
> will, but it will be some time as I am nearing the most important astronomy
> conference of the year for me.

No-one expects you to work miracles. :) Like I said, contributions are
always welcome; and yours are accompanied by more thorough research than
the average. Thanks!

> It will be several weeks before I can try to make
> a Windows svnserve. But someone out there must have already have a Windows build environment and could quickly make the patch and test.
>

Sure. (I just happen to not be one of those someones these days.)

So here's the situation as I see it:

    * Our current code works with Unix clients against Unix servers.
    * Bob's patch work with Windows clients against Unix servers, tested
      with the 2 (3?) relevant SSH clients for Windows.
    * I very much suspect that this issue is not affected by the server
      side, but think it would be nice if someone could test that.

Given all the above, and seeing as this doesn't appear to be something
easily remedied by an APR fix ... and assuming that the
Windows<->Windows test works out ... I'd propose we make the
Windows-specific change that Bob suggested.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2408506
Received on 2009-10-17 14:34:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.