[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix to use repository in root drive letter under win32

From: Branko Cibej <brane_at_xbc.nu>
Date: Wed, 14 Oct 2009 06:55:58 +0200

Hugo Bastos Weber wrote:
> [[[
> * subversion/libsvn_ra_local/split_url.c
> (svn_ra_local__split_URL): Allow file:///X:/ in addition to file:///X:/path. This fix allows one to use repository in the root drive lettler.
> ]]]

Isn't the log message wrong? You're not allowing file:///X:/ which is
already supported, but file:///X:. But that's not a canonical URL (we
"know" that /^[A-Za-z]:/ is a directory on Windows), and libsvn_ra_local
has no business accepting non-canonical paths. The bug is IMHO in the
code that calls, e.g., svn_ra_open with a non-canonical URL.

-- Brane

Received on 2009-10-14 06:56:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.