[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39964 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 13 Oct 2009 12:48:07 -0400

On Mon, Oct 12, 2009 at 15:56, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
>...
> +++ trunk/subversion/libsvn_wc/update_editor.c  Mon Oct 12 12:56:27 2009        (r39964)
>...
> +      if (kind == svn_wc__db_kind_unknown)
> +        break;
>
> -      ancestor_abspath = APR_ARRAY_IDX(ancestors, i, const char *);
> +      SVN_ERR(svn_wc__db_node_hidden(&hidden, db, ancestor_abspath, iterpool));
> +
> +      if (hidden)
> +        break;

An ancestor better not be missing or hidden. These checks are better
as an assertion.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407207
Received on 2009-10-14 00:04:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.