Re: svn commit: r39997 - trunk/tools/server-side

Daniel Shahaf wrote on Tue, 13 Oct 2009 at 22:03 +0200:
> David Glasser wrote on Tue, 13 Oct 2009 at 12:45 -0700:
> > On Oct 13, 2009 12:27 PM, "Daniel Shahaf" <tigris_at_danielsh.fastmail.net>
> > wrote:
> >
> > > +struct key_t
> > > +{
> > > + svn_revnum_t revision;
> > > + apr_off_t offset;
> > > +};
> > > +
> > > +/* What we need to know about a rep. */
> > > +struct value_t
> > > +{
> > > + svn_checksum_t *sha1_checksum;
> > > + apr_uint64_t refcount;
> > > +};
> ...
> > > + apr_hash_set(records, key, sizeof(*key), value);
> >
> > Is it legit to hash on a struct? Couldn't there be padding bytes?

Should I use apr_pcalloc() to allocate the key_t structs?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407310
Received on 2009-10-13 23:48:00 CEST