[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [RFC] Concept of RA session relative paths

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 13 Oct 2009 16:49:14 +0100

Bert Huijben wrote:
> > -----Original Message-----
> > From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> > Using full URLs like protocol://server/repo/path instead of session
> > relative path will be ideal solution. Another way is support both full
> > URLs and repository relative paths.
> One of the nice things of using just relative paths and not full urls
> is that we can leave all encoding issues (especially over http/https)
> to the ra layer implementations.
> It is very hard to escape special characters everywhere, and that is
> precisely what most of our current full uri apis require. Everywhere
> where we forget the escaping, we have a potential security issue.
> The new libsvn_wc code will not handle full uris internally. Only a
> repository root and paths relative from this root.
> Everywhere we need a full url, we can perform a single
> svn_path_url_add_component2() to handle the escaping of the relative
> path in one place. Forcing escaped uris through all of the code is not
> something I would like. (I fixed at least 5 or 6 issues caused by
> wrong escaping in the 1.5.X branch; and there are more open reports of
> similar issues that haven't been researched yet)

+1 to what Bert says.

I think we should in most cases be using a repository or session
"object" that knows its root URL.

- Julian

Received on 2009-10-13 23:47:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.