[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS/svn-rep-sharing-stats questions

From: David Glasser <glasser_at_davidglasser.net>
Date: Mon, 12 Oct 2009 16:54:54 -0700

I'm not clear on what exactly the data it prints is supposed to
represent. As implemented, it appears to be "the amount of
rep-sharing possible on this repository, if it had been entirely
written to in a world where rep-sharing exists". Is that what you
mean to have? Or are you trying to calculate how much rep-sharing is
actually accomplishing in the repository you're looking at?

Also, I'm not really sure that casting unsigned int<->void* is
technically well-defined.


On Mon, Oct 12, 2009 at 3:36 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Recently I added svn-rep-sharing-stats to the repository [1].  (It aims to
> be a tool for calculating reference counts for representations in an FSFS
> repository.)
> Since I'm not an FSFS expert, and wrote it partly based on the APIs and
> partly based on "doing it this way seems to work", I'll appreciate
> having some review on it.
> (What can go wrong?  Anything, I suppose, from FS corruption bugs to
> simple "doesn't calculate the refcounts correctly" bugs.)
> Most of the logic is in the functions process() and especially
> process_one_revision().
> Thanks.
> Daniel
> (who considers copying fsfs-reshard.py's always-on "This isn't ready to be
> used on live data" warning)
> [1] http://svn.collab.net/repos/svn/trunk/tools/server-side/svn-rep-sharing-stats.c
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2406831

glasser_at_davidglasser.net | langtonlabs.org | flickr.com/photos/glasser/
Received on 2009-10-13 23:14:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.