[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39975 - trunk/subversion/libsvn_wc

From: Philip Martin <philip_at_codematters.co.uk>
Date: Tue, 13 Oct 2009 19:17:29 +0100

Greg Stein <gstein_at_gmail.com> writes:

> On Tue, Oct 13, 2009 at 11:38, Philip Martin <philip_at_codematters.co.uk> wrote:
>> Greg Stein <gstein_at_gmail.com> writes:
>>> Author: gstein
>>> Date: Mon Oct 12 22:42:24 2009
>>> New Revision: 39975
>>> Log:
>>> Get rid of the "rerun" concept. Every operation should be able to be run
>>> multiple times, and it shouldn't matter whether it is the FIRST or an
>>> additional run.
>> That's the theory but does it work in practice?  How would I check?
>> This revision and r37254 have removed the debug code that demonstrated
>> how badly rerunning worked--there were loads of regression test
>> failures last time I tried it.
> It could very well fail in practice, but all these loggy operations
> are going to disappear in favor of wc_db functions and/or workqueue
> operations. As they get shifted, then we'll ensure they can be re-run
> (which I did with the killme op).

Without regression tests there is no guarantee that rerunning won't
get broken in future.

Also testing the individual operations isn't really enough--we need to
test the sequences of operations. Take issue 2424: the individual
moves are repeatable but the sequence is not (this particular
issue might get fixed in the new code).

> [...]
> Though it is a fair question to ask how we *ensure* and debug/test that.
> We can "easily" test running a given workqueue operation multiple
> times. It won't really be easy/possible to test a given operation
> failing partway through, however.

The log file mechanism was supposed to be interruptable and rerunnable
but running things twice was enough to show that it didn't work like
that in practice.

Received on 2009-10-13 22:57:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.