[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_client_status and path relativity

From: Roman Donchenko <DXDragon_at_yandex.ru>
Date: Mon, 12 Oct 2009 00:18:45 +0400

Hello,

While debugging the last Python testsuite failure, I've come upon an issue
in the info implementation.

First of all, as I've already mentioned in IRC, the receiver argument to
svn_client_info3 is of type svn_info_receiver2_t in the function
declaration, but svn_info_receiver_t in the definition. As both types are
identical, it doesn't cause any problems, but I'm listing it here for the
record.

Later on, however, in the aforementioned function we have:

   SVN_ERR(receiver(receiver_baton, base_name, info, pool));

Why are we passing it the base name here? The parameter is called
abspath_or_url, presumably it expects to be passed an absolute path or a
URL. 8=]

Moreover, I'm not sure what should be passed there. If we pass the URL in
the repository, then info_receiver_relpath_wrapper will be unable to
transform it into a relative path for svn_client_info2 users. And if we
use the absolute path in the WC, we still won't achieve full
compatibility: previously, "svn info mywc/blah.txt -rHEAD" would return
"blah.txt" as the path, now it would return "mywc/blah.txt". And I'm not
sure which one is a better answer. The latter appeals to me more, but it's
backwards incompatible.

Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2406436
Received on 2009-10-11 22:19:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.