[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39905 - trunk/subversion/tests/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sat, 10 Oct 2009 02:24:20 +0100

Greg Stein wrote:
> On Fri, Oct 9, 2009 at 19:35, Julian Foad wrote:
> > Daniel Shahaf wrote:
> >> Author: danielsh
> >> Date: Fri Oct 9 13:16:05 2009
> >> New Revision: 39905
> >>
> >> Log:
> >> Moving a file should preserve its changelist. Add tests to this effect.
> >>
> >> * subversion/tests/cmdline/changelist_tests.py
> >> (move_keeps_changelist, move_added_keeps_changelist):
> >> New tests.
> >> (test_list):
> >> Run them, XFail.
> >
> > In that case, "copy" should preserve the changelist on the copy too. I
> > don't know whether it does, just saying.
>
> I'm not sure that I agree.
>
> The changelist is associated with the specific node, so (IMO) it
> should move along with it.
>
> I don't see how a copy implies any similar kind of movement or
> extension of the changelist.

I suppose it depends on what kind of change you are tracking. I was
thinking of a whole new file for feature X, and that if I copy it then
it's likely that the copy is part of my feature X too. But if I'd just
made a small text change in X and then copied it, I'm probably wanting
the copy for some completely different purpose.

Actually, I also said what I said because I was thinking around the idea
that object identity should kind of follow the content, so both the
original and the copy have equal successorship status ... but that's in
the realm of thought experiments and not Subversion.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405743
Received on 2009-10-10 03:24:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.