[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Provide meaningful message when svn update is run against an out of date mirror.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 09 Oct 2009 13:27:37 -0400

Kamesh Jayachandran wrote:
> Hi All,
> In Web dav write through proxy setups following situation is common.
> 1. svn co http://mirror/svn/repo/trunk
> 2. cd trunk
> 3. modify test.c(assuming one such file exists)
> 4. svn ci -m "log message"
> 5. svn up #This has a very high chance of triggering the vague error of
> some working copy item having a rev > HEAD of mirror
> The attached patch fixes it.
> If there are no objections I will commit the same in a day or two.

I'm not fond at all of the idea of having code that is completely ignorant
of the fact that a proxy is or isn't in place (like mod_dav_svn's update
logic) generating errors that refer to mirrors.

A more appropriate approach would be for the mirror.c code (which is the
only code that really knows that some proxying is going on) to detect the
generic error and replace it with a more specific one in the returned
stream. That's probably quite a bit more work to achieve, but I believe it
is far more correct that what you are proposing.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2009-10-09 19:27:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.