Re: Any FSFS rep-sharing experts out there?

Daniel Shahaf wrote on Fri, 9 Oct 2009 at 00:22 +0200:
> David Glasser wrote on Thu, 8 Oct 2009 at 13:47 -0700:
> > On Thu, Oct 8, 2009 at 11:07 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > > I took a stab, see attached.

Committed in r39892. Further testing/reviews are still welcome, thanks.

> > So yeah, your patch looks good but I'd go two steps farther and run
> > the set_rep calls outside of the write lock and not in a transaction.
> >
>
> Per your other email, I'll move it outside the write lock.
>

I will do that in a followup commit.

> As suggested upthread, we may still want to make the code ignore BUSY
> errors when opening the DB (either for read or for write)

*After* the open, we do wait 10 seconds when sqlite signals BUSY:

  /* Retry until timeout when database is busy. */
  SQLITE_ERR_MSG(sqlite3_busy_timeout(*db3, BUSY_TIMEOUT),
                 sqlite3_errmsg(*db3));

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405484
Received on 2009-10-09 13:00:32 CEST