[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Any FSFS rep-sharing experts out there?

From: Mark Phippard <markphip_at_gmail.com>
Date: Thu, 8 Oct 2009 12:44:55 -0400

On Thu, Oct 8, 2009 at 12:40 PM, Branko Čibej <brane_at_xbc.nu> wrote:

>> 1) Why do we need to open this database when reading the repository?
>> Such as for a checkout?  My understanding is that the only time the
>> cache is needed is when we are writing to the database.  We want to
>> see if there is an existing representation for the same hash.  So why
>> should we care if this database is locked when someone is doing a
>> checkout?
> The rep-cache database gets opened deep within svn_fs_fs__open and
> svn_fs_fs__create. We don't really have a way to distinguish between
> open-for-read and open-for-write in svn_fs_open. I can't form an opinion
> right now on whether that's a serious omission or not, but in any case
> adding an open-mode would be a huge conceptional change, of the svn-2.0
> kind, IMHO.

I am not a C programmer, so I am speaking from a position of ignorance
here, but I do not see why we cannot just open the database at the
same point where we actually need to use it. It seems like poor
design to be opening the SQLite database every time the FS is
accessed, when it is only needed when we are committing something.
Especially thinking of people that have their repository on NFS or a
NetApp or something.

Mark Phippard
Received on 2009-10-08 18:46:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.