Re: [PATCH] Time taken to execute the test suite

Thank you for the review comments, Branko.

On Thu, 2009-10-08 at 11:41 +0200, Branko Čibej wrote:
>
> > if progbase[-3:] == '.py':
> > progname = sys.executable
> > cmdline = [quote(progname),
> > @@ -255,10 +257,14 @@
> > print(TextColors.FAILURE + 'FAILURE' + TextColors.ENDC)
> > else:
> > print(TextColors.SUCCESS + 'success' + TextColors.ENDC)
> > + endtime = int(time.time())
> > + epoch = endtime - starttime
> > + (hrs, mins, secs) = ((epoch/(60*60))%24, (epoch/60)%60, epoch%60)
> > + total_time = "%02d:%02d:%02d" % (hrs, mins, secs)
>
> elapsed_time = time.strftime('%H:%M:%S', time.time() - start_time)

The argument to time.strftime() method should be of type "list", not
"float". The above change complains:
  File "./build/run_tests.py", line 260, in _run_test
    elapsed_time = time.strftime('%H:%M:%S', time.time() - start_time)
TypeError: argument must be 9-item sequence, not float
make: *** [check] Error 1

May I incorporate rest of your review comments and attach the patch?

-- 
Bhuvaneswaran A    
CollabNet Software P Ltd.  |  www.collab.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2404875