Re: [PATCH] Invoke 'store password' prompt for all commands requiring authentication

On Wed, Oct 07, 2009 at 12:27:07PM +0530, Kannan wrote:
> Log:
> While working on a wc of a repo which needs authentication, 'store
> password unencrypted' prompt is getting invoked only for those svn
> commands that access the repo URL or that have an URL as argument
> (eg. svn ls http://localhost/repo) and not for wc oriented commands
> such as `svn ls' or `svn cat -r 5 test.c' which also require
> authentication. The prompt gets invoked for the rest of the commands
> which need repo access, with the following patch.
>
> * subversion/libsvn_ra_neon/session.c
> (svn_ra_neon__get_repos_root) : Call
> `svn_ra_neon__maybe_store_auth_info' to invoke 'store
> password unencrypted' prompt.
>

I'm not familiar enough with ra-neon to decide whether this patch
is OK, but I have a related question:

I noticed the prompt does not show up during 'svn propedit' either.
E.g. when I do: 'svn propedit --revprop -rX svn:log
https://svn.collab.net/... ' I have to enter my password after exiting
the editor but svn never asks me whether it should store the password
in plaintext (as it does when I make a commit).

Does this patch fix this case, too?

Thanks,
Stefan

> Index: session.c
> ===================================================================
> --- session.c (revision 39675)
> +++ session.c (working copy)
> @@ -1099,6 +1099,7 @@
> }
>
> *url = ras->repos_root;
> + SVN_ERR(svn_ra_neon__maybe_store_auth_info(ras, pool));
> return SVN_NO_ERROR;
> }
>

-- 
printf("Eh???/n");
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2404437