[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Workaround for missing ERROR_DIRECTORY constant in APR

From: Branko Cibej <brane_at_xbc.nu>
Date: Sat, 03 Oct 2009 15:02:40 +0200

If you're building everything from source, you could try this patch for
APR -- it should apply unchanged to trunk, 1.3 and 1.4; possibly older
versions too, but I haven't checked.

http://svn.apache.org/viewvc/apr/apr/trunk/include/apr_errno.h?r1=659285&r2=821306&pathrev=821306

-- Brane

Wolfgang Stengel wrote:
> Hello Subversion team,
>
> please consinder the attached patch. Some file systems (for example NFS)
> produce a different error code on Windows than that which is handled by
> APR natively. This results in a number of problems with Subversion, for
> example the function svn_wc_check_wc() does not fail correctly on
> inexistant files.
>
> The attached patch provides a simple workaround. It mappes the
> error code ERROR_DIRECTORY to the error code ERROR_PATH_NOT_FOUND which
> can be caught by the APR_STATUS_IS_ENOTDIR() macro. The patch also
> checks if the constant ERROR_DIRECTORY even exists and if the problem
> in APR has been fixed in the meantime (by checking if
> APR_STATUS_IS_ENOENT() or APR_STATUS_IS_ENOTDIR() already catch
> ERROR_DIRECTORY).
>
> Thank you for your opinions on this.
>
> Wolfgang
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2403203
Received on 2009-10-03 15:02:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.