[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39635 - in trunk/subversion/bindings/swig: . include python/libsvn_swig_py

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 01 Oct 2009 18:11:48 +0100

Stefan Sperling wrote:
> > + APR_ARRAY_IDX(temp, targlen, void *) = struct_ptr;
>
> You could use APR_ARRAY_PUSH(temp, void *) = struct_ptr; here.
> That would align better with common use of arrays in our code,
> PUSH is usually used for writing to the array, IDX for retrieval.

No, PUSH is different: it means extend the array by one element and then
set that element.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2402614
Received on 2009-10-01 19:12:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.