[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: segfault with 1.6.x client

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 1 Oct 2009 11:40:03 +0100

On Wed, Sep 30, 2009 at 04:12:18PM -0500, Peter Samuelson wrote:
> Bjorn Tipling reports this on IRC. I've reproduced it in 1.6.5.
> In a working copy:
>
> $ svn mkdir foo
> A foo
> $ mv foo ..
> $ svn revert foo
> Reverted 'foo'
> $ mv ../foo .
> $ svn rm --force foo
>
> Segmentation fault, and the wc is left in 'locked' state.

I can reproduce it with 1.6.x, too.

Trunk does not segfault:

$ svn rm --force foo
subversion/svn/delete-cmd.c:91: (apr_err=155010)
subversion/svn/util.c:900: (apr_err=155010)
subversion/libsvn_client/delete.c:294: (apr_err=155010)
subversion/libsvn_wc/adm_ops.c:1203: (apr_err=155010)
subversion/libsvn_wc/entries.c:1287: (apr_err=155010)
svn: '/tmp/2/svn-sandbox/trunk/foo' is not under version control

It was fixed by Neels on trunk as part of r37953.
Nominating the NULL check added in that revision fixes it.
I'll make a backport branch for r37953 that will contain the NULL check only.

1.6.x behaviour with this fix:

 $ svn st
 ? foo
 $ svn cleanup
 $ svn rm --force foo
 svn: Working copy 'foo' locked
 svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
 $ svn st
 ? foo
 $ ls -a foo/
 ./ ../ .svn/
 $ svn cleanup foo
 $ svn rm --force foo
 D foo
 $ svn st
 $

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2402436
Received on 2009-10-01 12:40:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.