[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.6.x and r38000

From: Stephen Butler <sbutler_at_elego.de>
Date: Tue, 29 Sep 2009 19:36:27 +0200

Quoting "Hyrum K. Wright" <hyrum_at_hyrumwright.org>:

> On Sep 28, 2009, at 9:49 AM, Julian Foad wrote:
>> On Fri, 2009-09-25 at 17:11 +0100, Julian Foad wrote:
>>> On Tue, 2009-09-15, Julian Foad wrote:
>>> I've now reviewed the main parts of 1.6.x-r38000_at_HEAD and am happy.
>>> Now
>>> I've "just" got to review the test and repos_diff.c.
>>> Please put your +1 there anyway if you can, or +0 if that's how it
>>> is,
>>> and if Stephen can review the latest changes and +1 them we will be
>>> nearly there.

Hi folks,

The current state of the r38000 group looks good to me, except for a
couple of test failures over HTTP. I'm running on OS X 10.6 with
apr 1.3.8, httpd 2.2.12, neon 29.0, and serf 0.3.0. The failures

merge_tests.py 133

Over HTTP, there's a redundant notification of a tree-conflicted dir
(A/B/E: "local edit, incoming delete upon merge"). This test is new.
It's had problems before, and is currently skipped over serf.


If I get rid of the Skip() I get the same results over neon and serf.
Does this test fail over neon for anyone else?

switch_tests.py 19

This test changes a prop of a dir that's been deleted in the repo,
then commits. The commit should fail with "out of date". Over HTTP
it succeeds.

Looking at the httpd access_log, I see the old "PROPPATCH that
succeeds" behavior mentioned a while back on the dev-list.


But it looks like r37745 was already merged to 1.6.x. This test fails
on ^/branches/1.6.x, too. IMHO it shouldn't delay merging the r38000


Stephen Butler | Software Developer
elego Software Solutions GmbH
Gustav-Meyer-Allee 25 | 13355 Berlin | Germany
fon: +49 30 2345 8696 | mobile: +49 163 25 45 015
fax: +49 30 2345 8695 | http://www.elegosoft.com
Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin
Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
Received on 2009-09-29 19:36:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.