[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39602 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 25 Sep 2009 11:28:00 -0400

On Fri, Sep 25, 2009 at 10:16, Stefan Sperling <stsp_at_elego.de> wrote:
> Author: stsp
> Date: Fri Sep 25 07:16:51 2009
> New Revision: 39602
>
> Log:
> * subversion/libsvn_subr/prompt.c
>  (prompt): Document a GCC warning we will never get rid of.
>
> Modified:
>   trunk/subversion/libsvn_subr/prompt.c
>
> Modified: trunk/subversion/libsvn_subr/prompt.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/prompt.c?pathrev=39602&r1=39601&r2=39602
> ==============================================================================
> --- trunk/subversion/libsvn_subr/prompt.c       Fri Sep 25 07:09:46 2009        (r39601)
> +++ trunk/subversion/libsvn_subr/prompt.c       Fri Sep 25 07:16:51 2009        (r39602)
> @@ -132,6 +132,8 @@ prompt(const char **result,
>             }
>           else if (c == APR_EOL_STR[0])
>             {
> +              /* GCC might complain here: "warning: will never be executed"
> +               * That's fine. This is a compile-time check for "\r\n\0" */
>               if (sizeof(APR_EOL_STR) == 3)
>                 {

I believe you can legally check this in a #if directive.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2400289
Received on 2009-09-25 17:28:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.