[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Test suite --http-library switch [was: FAIL: merge_tests.py 132: replace vs. edit tree-conflicts]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 25 Sep 2009 13:18:20 +0100

C. Michael Pilato wrote:
> I noticed today that when I ran 'make davcheck', merge_tests.py test 132
> failed. Figuring it was a serf thang, I re-ran just that test over neon
> (using "--http-library neon") -- it passed. Just to make sure, I ran it
> with "--http-library serf" -- it ... was skipped?!
>
> Anyway, I'm guessing that what happens is that the
> svntest.main.is_ra_type_dav_serf flag (which this test is checking as a
> condition for skipping) only gets set if the command-line arguments
> specifically indicate that serf is being used, and that if no --http-library
> option is provided, the test suite simply hasn't the ability to figure out
> which WebDAV RA module is going to get used (since that all depends on
> what's been compiled-in, etc.).
>
> This may all be common knowledge for folks, but in the event that it isn't,
> I thought I'd share.

It looks like the test suite assumed the default was Neon, which it was
up until 1.6.

Please try the attached patch, which removes the assumption of a
particular built-in default, provides its own default (serf) if the
option is not provided, and clarifies the detection code.

We could go further and make the test suite check at start-up that "svn
--version" confirms that the chosen HTTP library is in fact supported.
Better still, perhaps make "svn --version" tell us which one is
currently selected for use.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2400209

Received on 2009-09-25 14:18:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.